> -----Original Message----- > From: Xin Long [mailto:lucien....@gmail.com] > Sent: 26 March 2017 17:21 > To: network dev; linux-s...@vger.kernel.org > Cc: da...@davemloft.net; Marcelo Ricardo Leitner; Neil Horman; David Laight > Subject: [PATCHv2 net] sctp: change to save MSG_MORE flag into assoc > > David Laight noticed the support for MSG_MORE with datamsg->force_delay > didn't really work as we expected, as the first msg with MSG_MORE set > would always block the following chunks' dequeuing. > > This Patch is to rewrite it by saving the MSG_MORE flag into assoc as > David Laight suggested. > > asoc->force_delay is used to save MSG_MORE flag before a msg is sent. > All chunks in queue would not be sent out if asoc->force_delay is set > by the msg with MSG_MORE flag, until a new msg without MSG_MORE flag > clears asoc->force_delay. > > Note that this change would not affect the flush is generated by other > triggers, like asoc->state != ESTABLISHED, queue size > pmtu etc. > > v1->v2: > Not clear asoc->force_delay after sending the msg with MSG_MORE flag. > > Fixes: 4ea0c32f5f42 ("sctp: add support for MSG_MORE") > Signed-off-by: Xin Long <lucien....@gmail.com> > ---
Acked-by: David Laight <david.lai...@aculab.com> I'll get around to testing it yet :-) David