> -----Original Message----- > From: Joe Perches [mailto:j...@perches.com] > Sent: Friday, March 31, 2017 4:45 PM > To: Salil Mehta; da...@davemloft.net > Cc: Zhuangyuzeng (Yisen); mehta.salil....@gmail.com; > netdev@vger.kernel.org; linux-ker...@vger.kernel.org; Linuxarm > Subject: Re: [PATCH V2 net-next 18/18] net: hns: Some checkpatch.pl > script & warning fixes > > On Fri, 2017-03-31 at 12:20 +0100, Salil Mehta wrote: > > This patch fixes some checkpatch.pl script caught errors and > > warnings during the compilation time. > [] > > diff --git a/drivers/net/ethernet/hisilicon/hns/hns_enet.c > b/drivers/net/ethernet/hisilicon/hns/hns_enet.c > [] > > @@ -512,7 +512,8 @@ static void hns_nic_reuse_page(struct sk_buff > *skb, int i, > > int last_offset; > > bool twobufs; > > > > - twobufs = ((PAGE_SIZE < 8192) && hnae_buf_size(ring) == > HNS_BUFFER_SIZE_2048); > > + twobufs = ((PAGE_SIZE < 8192) && hnae_buf_size(ring) > > + == HNS_BUFFER_SIZE_2048); > > This would read nicer without splitting a comparison test > onto multiple lines > > twobufs = PAGE_SIZE < 8192 && > hnae_buf_size(ring) == HNS_BUFFER_SIZE_2048; For sure, thanks for noticing. Will correct this!
Best regards Salil >
