On Mon, Apr 03, 2017 at 11:14:36AM +0200, Corentin Labbe wrote:
> The dwmac-sun8i hardware is present on the Orange PI plus.
> It uses an external PHY rtl8211e via RGMII.
> 
> This patch create the needed regulator, emac and phy nodes.
> 
> Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com>
> ---
>  arch/arm/boot/dts/sun8i-h3-orangepi-plus.dts | 36 
> ++++++++++++++++++++++++++++
>  1 file changed, 36 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/sun8i-h3-orangepi-plus.dts 
> b/arch/arm/boot/dts/sun8i-h3-orangepi-plus.dts
> index 8c40ab7..6852006 100644
> --- a/arch/arm/boot/dts/sun8i-h3-orangepi-plus.dts
> +++ b/arch/arm/boot/dts/sun8i-h3-orangepi-plus.dts
> @@ -58,6 +58,18 @@
>               enable-active-high;
>               gpio = <&pio 6 11 GPIO_ACTIVE_HIGH>;
>       };
> +
> +     reg_gmac_3v3: gmac-3v3 {
> +             compatible = "regulator-fixed";
> +             pinctrl-names = "default";
> +             pinctrl-0 = <&gmac_power_pin_orangepi>;
> +             regulator-name = "gmac-3v3";
> +             regulator-min-microvolt = <3300000>;
> +             regulator-max-microvolt = <3300000>;
> +             startup-delay-us = <100000>;
> +             enable-active-high;
> +             gpio = <&pio 3 6 GPIO_ACTIVE_HIGH>;
> +     };
>  };
>  
>  &ehci3 {
> @@ -86,8 +98,32 @@
>               pins = "PG11";
>               function = "gpio_out";
>       };
> +
> +     gmac_power_pin_orangepi: gmac_power_pin@0 {
> +             pins = "PD6";
> +             function = "gpio_out";
> +             drive-strength = <10>;
> +     };

This is not needed, and will even harm the fixing of a bug that will
require to remove all the GPIO nodes. It works fine without it, please
remove it.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Attachment: signature.asc
Description: PGP signature

Reply via email to