On Mon, Apr 3, 2017 at 9:26 AM, Gao Feng <gfree.w...@foxmail.com> wrote:
>>
>> Looks OK to me.
>>
>> IMHO this is a nice direction, since there is a proposal to increase the
>> maximum
>> shift factor from 14 to 15:
>> https://tools.ietf.org/html/draft-nishida-tcpm-maxwin-03
>
> Do you mean enlarge the wscale to 15 now ?
No, I just meant that it will be easier to change if we ever decide to
change this to 15.
>> Though there are a few spots where a literal 14 appears:
>>
>> tcp_input.c:3763: net_info_ratelimited("%s: Illegal window scaling
>> value %d >14 received\n",
>>
>> tcp_output.c:238: * See RFC1323 for an explanation of
>> the limit to 14
>
> Ok, I will update these two spots.
OK, thanks.
neal
