On 04/06/2017 03:00 AM, Russell King - ARM Linux wrote: > This set of two patches fixes and cleans up the phylib code associated > with selecting the fixed mode. > > phylib currently assumes that all PHYs will support the 10baseT/Half mode > of operation irrespective of the supported bitmask, because of the way > phy_find_valid() and phy_find_setting() operate. > > This series resolves that by reimplementing the table lookup, filtering > out all unsupported modes. This results in an unsupported speed setting > always choosing one of the speeds that are supported by the PHY. Full > details are in the patch commit log. > > The second patch cleans up the loop in phy_supported_speeds().
This looks totally fine to me, do you mind resubmitting as non RFC? > > drivers/net/phy/phy.c | 119 > ++++++++++++++++++++++++++++---------------------- > 1 file changed, 68 insertions(+), 51 deletions(-) > > v1->v2: fixed 0-day build errors > -- Florian
