On 2017/4/11 22:47, David Miller wrote:
> From: Jie Deng <jie.de...@synopsys.com> > Date: Tue, 11 Apr 2017 16:14:04 +0800 > >> It is necessary to provide ethtool support for displaying and >> modifying parameters of dwc-xlgmac. >> >> Signed-off-by: Jie Deng <jied...@synopsys.com> > I don't see why you cannot allow the statistics to be obtained when > the device is not running. Similarly for other ethtool calls that > just fetch information stored in the software state of the driver. > > I think your ->begin() method is way too restrictive. Yeah, begin() seems unreasonable here. I will remove it.
