On Thu, Apr 20, 2017 at 3:43 PM, David Ahern <d...@cumulusnetworks.com> wrote: > > I scanned the others. It is not clear that others should fail with > EINVAL. Certainly a mask of unused flags can be added, but to me that is > on top of this bug fix. >
If we want to preserve those unused bits, we should reject them too. RTF_PCPU is special here, it is used but only internally, so it makes sense to silently clear it since we don't care whether people set it to 1 or 0. We should clear it for dumping too since it is internal only.
