From: Guillaume Chazarain <[EMAIL PROTECTED]>
Date: Sun, 16 Jul 2006 23:56:31 +0200

> CONFIG_DEBUG_SLAB found the following bug:
> netem_enqueue() in sch_netem.c gets a pointer inside a slab object:
> struct netem_skb_cb *cb = (struct netem_skb_cb *)skb->cb;
> But then, the slab object may be freed:
> skb = skb_unshare(skb, GFP_ATOMIC)
> cb is still pointing inside the freed skb, so here is a patch to
> initialize cb later, and make it clear that initializing it sooner
> is a bad idea.
> 
> [From Stephen Hemminger: leave cb unitialized in order to let gcc
> complain in case of use before initialization]

Looks good to me, applied, thanks a lot.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to