On Thu, Apr 27, 2017 at 5:46 AM, Eric Dumazet <[email protected]> wrote: > On Wed, 2017-04-26 at 13:55 -0700, Cong Wang wrote: >> After commit 1215e51edad1 ("ipv4: fix a deadlock in ip_ra_control") >> we always take RTNL lock for ip_ra_control() which is the only place >> we update the list ip_ra_chain, so the ip_ra_lock is no longer needed, >> we just need to disable BH there. >> >> Signed-off-by: Cong Wang <[email protected]> >> --- > > Looks great, but reading again this code, I believe we do not need to > disable BH at all ? >
Hmm, if we don't disable BH here, a reader in BH could jump in and break this critical section? Or that is fine for RCU?
