On Mon, May 8, 2017 at 4:11 AM, Hangbin Liu <liuhang...@gmail.com> wrote: > After call ip6_tnl_err(), the rel_type will be ether ICMPV6_DEST_UNREACH > or ICMPV6_PKT_TOOBIG. We will never reach ICMP_REDIRECT. So remove it.
Are you sure we really don't need to handle NDISC_REDIRECT here? I can't find anything in RFC 2473 explictly, but I am feeling we should handle it rather than ignoring it according to: To report a problem detected inside the tunnel to the source of an original packet, the tunnel entry point node must relay the ICMP message received from inside the tunnel to the source of that original IPv6 packet. I am not sure...
