On 05/24/2017 04:07 PM, Florian Fainelli wrote: > Hi Andrew, > > On 05/24/2017 01:10 PM, Andrew Lunn wrote: >>> +What: /sys/class/mdio_bus/<bus>/<device>/phy_interface >>> +Date: February 2014 >>> +KernelVersion: 3.15 >>> +Contact: netdev@vger.kernel.org >>> +Description: >>> + String value indicating the PHY interface, possible >>> + values are in include/linux/phy.h function phy_modes. >> >> Hi Florian >> >> Does this suggest that these strings should be moved to >> include/uapi/linux/phy.h? > > Humm, I suppose we could do that, although I am not sure ally sure what > we would be putting in there (at least for now).
I actually prefer to put the possible values in the sysfs documentation files instead of in a UAPI header. Will submit a v2. -- Florian