From: Andrew Lunn <and...@lunn.ch>
Date: Tue, 23 May 2017 23:24:55 +0200
> EXT_ADDR_PAGE is the same meaning as MII_MARVELL_PHY_PAGE, i.e. change
> page. Replace it will calls to the helpers.
>
> Signed-off-by: Andrew Lunn <and...@lunn.ch>
Sorry to ding you on this but...
> @@ -1556,12 +1552,19 @@ static int m88e1121_get_temp(struct phy_device
> *phydev, long *temp)
> {
> int ret;
> int val;
> + int oldpage;
Reverse christmas tree.
> @@ -1671,12 +1674,19 @@ static const struct hwmon_chip_info
> m88e1121_hwmon_chip_info = {
> static int m88e1510_get_temp(struct phy_device *phydev, long *temp)
> {
> int ret;
> + int oldpage;
>
> *temp = 0;
Likewise.
> @@ -1696,12 +1706,18 @@ static int m88e1510_get_temp(struct phy_device
> *phydev, long *temp)
> int m88e1510_get_temp_critical(struct phy_device *phydev, long *temp)
> {
> int ret;
> + int oldpage;
>
> *temp = 0;
Likewise.
> @@ -1724,10 +1740,17 @@ int m88e1510_get_temp_critical(struct phy_device
> *phydev, long *temp)
> int m88e1510_set_temp_critical(struct phy_device *phydev, long temp)
> {
> int ret;
> + int oldpage;
Likewise.
> @@ -1751,12 +1774,19 @@ int m88e1510_set_temp_critical(struct phy_device
> *phydev, long temp)
> int m88e1510_get_temp_alarm(struct phy_device *phydev, long *alarm)
> {
> int ret;
> + int oldpage;
Likewise.
Otherwise this patch series looks fine to me.
THanks.
