Thu, May 25, 2017 at 06:14:56PM CEST, da...@davemloft.net wrote:
>From: Cong Wang <xiyou.wangc...@gmail.com>
>Date: Tue, 23 May 2017 09:42:37 -0700
>
>> tcf_chain_get() always creates a new filter chain if not found
>> in existing ones. This is totally unnecessary when we get or
>> delete filters, new chain should be only created for new filters
>> (or new actions).
>>
>> Fixes: 5bc1701881e3 ("net: sched: introduce multichain support for filters")
>> Cc: Jamal Hadi Salim <j...@mojatatu.com>
>> Cc: Jiri Pirko <j...@mellanox.com>
>> Signed-off-by: Cong Wang <xiyou.wangc...@gmail.com>
>
>Indeed, get and delete requests should not create new objects, ever.
>
>I have pretty much no idea why Jiri is making such a big fuss about
>this change, to be quite honest. :-)
Because it makes already hard to read code even worse, for *no* benefit.
That's why.
>
>Applied, thanks Cong.
