On 05/30/2017 02:26 PM, Vlad Yasevich wrote:
> On 05/30/2017 01:12 PM, Stephen Hemminger wrote:
>> On Sat, 27 May 2017 10:14:36 -0400
>> Vladislav Yasevich <[email protected]> wrote:
>>
>>>
>>> +static const char *netdev_events[] = {"NONE",
>>> + "REBOOT",
>>> + "FEATURE CHANGE",
>>> + "BONDING FAILOVER",
>>> + "NOTIFY PEERS",
>>> + "RESEND IGMP",
>>> + "BONDING OPTION"};
>>
>> Overall this looks fine, I will pickup the if_link.h from net-next.
>>
>> One stylistic change.
>>
>> Please add simple line break, and initialize by value:
>>
>> static const char *netdev_events[] = {
>> [IFLA_EVENT_NONE] = "NONE",
>> ...
>>
>> Do you want some prefix or bounding around the event output?
>
> Don't really care about output from my side. If you think some prefix
> would be good, I can surely add it.
>
>> Also a little concerned that the output format change may break some program
>> could the new output be at the end of the line?
>>
>
> I can try moving it to the end.
>
Hi Stephen
So, I looked again at this patch and the output change I am proposing would look
something like this 'ip monitor':
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 6500 qdisc noqueue state UNKNOWN group
default event
FEATURE CHANGE
link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
It's already at the end of the like ant has an 'event' prefix similar to all
the other
entries on the top line. Does that look OK? I don't think that would break
anything.
Thanks
-vlad
