The packets per slave parameter used by round robin mode does not have a printk
debug
message in its set function in bond_options.c. Adding such a function would aid
debugging
of round-robin mode and allow the user to more easily verify that the parameter
has been
set correctly. I should add that I'm motivated by my own experience here - it's
not
obvious from output of tools such as wireshark and ifstat that the parameter is
working
correctly, and with the differences in bonding configuration across different
distributions,
it would have been comforting to see this output.
Signed-off-by: Michael Dilmore <michael.j.dilm...@gmail.com>
cc: Veaceslav Falico <vfal...@gmail.com>,Andy Gospodarek
<a...@greyhouse.net>,netdev@vger.kernel.org,linux-ker...@vger.kernel.org
---
drivers/net/bonding/bond_options.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/bonding/bond_options.c
b/drivers/net/bonding/bond_options.c
index 1bcbb8913e17..4da0de1bab0a 100644
--- a/drivers/net/bonding/bond_options.c
+++ b/drivers/net/bonding/bond_options.c
@@ -1233,6 +1233,8 @@ static int bond_option_lp_interval_set(struct bonding
*bond,
static int bond_option_pps_set(struct bonding *bond,
const struct bond_opt_value *newval)
{
+ netdev_info(bond->dev, "Setting packets per slave to %d\n",
+ newval->value);
bond->params.packets_per_slave = newval->value;
if (newval->value > 0) {
bond->params.reciprocal_packets_per_slave =
--
2.11.0
