From: Julian Wiedmann <j...@linux.vnet.ibm.com> Date: Mon, 19 Jun 2017 13:22:25 +0200
> +{ > + struct diag26c_mac_req *request; > + struct diag26c_mac_resp *response; > + struct ccw_dev_id id; > + int rc; > + Please order local variable declarations from longest to shortest line (reverse christmas tree). > + if ((request->resp_buf_len < sizeof(*response)) || > + (response->version != request->resp_version)) { Excessive parenthesis here. Thanks.