> Is my reading correct that in case the reason is not in the > pddr2ethtool_table opaque binary data will be passed from the firmware > to user space? Is there any particular reason to allow for this? If > it's just for the rare scenario where a new error code needs to be > added perhaps it would be enough to dump the FW-provided message to the > logs?
No binary data is passed in this patch, the monitor_opcode is simply a vendor specific 16 bit id that is used when the reason is not generic enough to have it's own enum.