Re: [PATCH 01/11] net: phy: Add rockchip phy driver support

[Andrew Lunn]

> +
> +static int internal_config_init(struct phy_device *phydev)
> +{

internal_ is a bit generic. The Marvell Ethernet switches have
internal phy, etc. rockchip_ would be a better prefix.

         Andrew