On Tue, 2006-08-01 at 23:19 +1000, Herbert Xu wrote: > Arjan van de Ven <[EMAIL PROTECTED]> wrote: > > > > we fixed lockdep to have this lock key to be per skb queue ... didn't > > you put that patch in rawhide Dave (J) ? > > I've only briefly looked at the lockdep_set_class code so I might be > way off here. > > It seems that for lockdep_set_class to work its second argument should > be distinct for each class of locks that you wish to distinguish. So > shouldn't we be putting the key into struct sk_buff_head rather than > having one key (skb_queue_lock_key) for all sk_buff_head's? >
fwiw the patch is at http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.18-rc2/2.6.18-rc2-mm1/broken-out/lockdep-split-the-skb_queue_head_init-lock-class.patch and a followup cleanup at http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.18-rc2/2.6.18-rc2-mm1/broken-out/lockdep-split-the-skb_queue_head_init-lock-class-tidy.patch - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
