On 07/10/2017 11:30 AM, Jesper Dangaard Brouer wrote: > On Sat, 8 Jul 2017 21:06:17 +0200 > Jesper Dangaard Brouer <bro...@redhat.com> wrote: > >> On Sat, 08 Jul 2017 10:46:18 +0100 (WEST) >> David Miller <da...@davemloft.net> wrote: >> >>> From: John Fastabend <john.fastab...@gmail.com> >>> Date: Fri, 07 Jul 2017 10:48:36 -0700 >>> >>>> On 07/07/2017 10:34 AM, John Fastabend wrote: >>>>> This series adds two new XDP helper routines bpf_redirect() and >>>>> bpf_redirect_map(). The first variant bpf_redirect() is meant >>>>> to be used the same way it is currently being used by the cls_bpf >>>>> classifier. An xdp packet will be redirected immediately when this >>>>> is called. >>>> >>>> Also other than the typo in the title there ;) I'm going to CC >>>> the driver maintainers working on XDP (makes for a long CC list but) >>>> because we would want to try and get support in as many as possible in >>>> the next merge window. >>>> >>>> For this rev I just implemented on ixgbe because I wrote the >>>> original XDP support there. I'll volunteer to do virtio as well. >>> >>> I went over this series a few times and it looks great to me. >>> You didn't even give me some coding style issues to pick on :-) >> >> We (Daniel, Andy and I) have been reviewing and improving on this >> patchset the last couple of weeks ;-). We had some stability issues, >> which is why it wasn't published earlier. My plan is to test this >> latest patchset again, Monday and Tuesday. I'll try to assess stability >> and provide some performance numbers. > > > Damn, I though it was stable, I have been running a lot of performance > tests, and then this just happened :-(
Thanks, I'll take a look through the code and see if I can come up with why this might happen. I haven't hit it on my tests yet though. .John
