On Wed, 19 Jul 2017 23:19:33 -0600
"Philip Prindeville" <phil...@redfish-solutions.com> wrote:

> From: Philip Prindeville <phil...@redfish-solutions.com>
> 
> In the presence of firewalls which improperly block ICMP Unreachable
> (including Fragmentation Required) messages, Path MTU Discovery is
> prevented from working.
> 
> The workaround is to handle IPv4 payloads opaquely, ignoring the DF bit.
> 
> Reviewed-by: Stephen Hemminger <step...@networkplumber.org>
> Signed-off-by: Philip Prindeville <phil...@redfish-solutions.com>
> ---
>  doc/ip-cref.tex      |  7 +++++++
>  ip/link_gre.c        | 16 ++++++++++++++++
>  man/man8/ip-tunnel.8 |  9 +++++++++
>  3 files changed, 32 insertions(+)
> 

Please fix Subject line and the following minor checkpatch warnings and resubmit


WARNING: line over 80 characters
#109: FILE: ip/link_gre.c:170:
+                       ignore_df = 
!!rta_getattr_u8(greinfo[IFLA_GRE_IGNORE_DF]);

WARNING: Block comments use a trailing */ on a separate line
#121: FILE: ip/link_gre.c:322:
+                       // only the lsb is significant, use 2 for presence */

total: 0 errors, 2 warnings, 86 lines checked

Reply via email to