OK, we will use module_pci_driver although it is not very common in the same segment.
On 7/25/2017 11:02 PM, Francois Romieu wrote: > Aviad Krawczyk <aviad.krawc...@huawei.com> : > [...] >> module_pci_driver - is not used in other drivers in the same segments, it >> is necessary ? > > /me checks... Ok, there seems to be some overenthusiastic copy'paste. > > See drivers/net/ethernet/intel/ixgb/ixgb_main.c: > [...] > /** > * ixgb_init_module - Driver Registration Routine > * > * ixgb_init_module is the first routine called when the driver is > * loaded. All it does is register with the PCI subsystem. > **/ > > static int __init > ixgb_init_module(void) > { > pr_info("%s - version %s\n", ixgb_driver_string, ixgb_driver_version); > pr_info("%s\n", ixgb_copyright); > > return pci_register_driver(&ixgb_driver); > } > > module_init(ixgb_init_module); > > /** > * ixgb_exit_module - Driver Exit Cleanup Routine > * > * ixgb_exit_module is called just before the driver is removed > * from memory. > **/ > > static void __exit > ixgb_exit_module(void) > { > pci_unregister_driver(&ixgb_driver); > } > > module_exit(ixgb_exit_module); > > Driver version ought to be fed through ethtool, if ever. Copyright message > mildly contributes to a better world. So the whole stuff above could be: > > module_pci_driver(ixgb_driver); >