On 08/03/2017 04:16 PM, Stephen Hemminger wrote:
> On Fri, 4 Aug 2017 00:07:45 +0100
> "Jianming.qiao" <jqiao...@gmail.com> wrote:
>
>> static const struct bcm_sysport_stats bcm_sysport_gstrings_stats[] = {
>> /* general stats */
>> - STAT_NETDEV(rx_packets),
>> - STAT_NETDEV(tx_packets),
>> - STAT_NETDEV(rx_bytes),
>> - STAT_NETDEV(tx_bytes),
>> + STAT_NETDEV64(rx_packets),
>> + STAT_NETDEV64(tx_packets),
>> + STAT_NETDEV64(rx_bytes),
>> + STAT_NETDEV64(tx_bytes),
>> STAT_NETDEV(rx_errors),
>
> Please don't duplicate regular statistics (ie netdev) into ethtool.
> It is a needless duplication.
Agreed, but these are there already and this driver's ethtool::get_stats
is an user ABI of some sort, is not it?
--
Florian
