From: Xin Long > Sent: 05 August 2017 13:00 > This patch is to remove the typedef sctp_scope_policy_t and keep > it's members as an anonymous enum. > > It is also to define SCTP_SCOPE_POLICY_MAX to replace the num 3 > in sysctl.c to make codes clear. > > Signed-off-by: Xin Long <lucien....@gmail.com> > --- > include/net/sctp/constants.h | 6 ++++-- > net/sctp/sysctl.c | 2 +- > 2 files changed, 5 insertions(+), 3 deletions(-) > > diff --git a/include/net/sctp/constants.h b/include/net/sctp/constants.h > index 922fba5..acb03eb 100644 > --- a/include/net/sctp/constants.h > +++ b/include/net/sctp/constants.h > @@ -341,12 +341,14 @@ typedef enum { > SCTP_SCOPE_UNUSABLE, /* IPv4 unusable addresses */ > } sctp_scope_t; > > -typedef enum { > +enum { > SCTP_SCOPE_POLICY_DISABLE, /* Disable IPv4 address scoping */ > SCTP_SCOPE_POLICY_ENABLE, /* Enable IPv4 address scoping */ > SCTP_SCOPE_POLICY_PRIVATE, /* Follow draft but allow IPv4 private > addresses */ > SCTP_SCOPE_POLICY_LINK, /* Follow draft but allow IPv4 link > local addresses */ > -} sctp_scope_policy_t; > +}; > + > +#define SCTP_SCOPE_POLICY_MAX SCTP_SCOPE_POLICY_LINK
Perhaps slightly better to end the enum with: SCTP_SCOPE_POLICY_COUNT, /* Number of policies */ SCTP_SCOPE_POLICY_MAX = SCTP_SCOPE_POLICY_COUNT - 1 /* Last policy */ }; David