Wei Yongjun <[EMAIL PROTECTED]> wrote:
> 
> --- a/net/ipv4/tcp_output.c     2006-08-03 18:05:22.425081936 -0400
> +++ b/net/ipv4/tcp_output.c     2006-08-07 09:48:41.186372896 -0400
> @@ -462,7 +462,8 @@ static int tcp_transmit_skb(struct sock 
>        if (skb->len != tcp_header_size)
>                tcp_event_data_sent(tp, skb, sk);
> 
> -       TCP_INC_STATS(TCP_MIB_OUTSEGS);
> +       if(!before(tcb->seq, tp->snd_nxt))
> +               TCP_INC_STATS(TCP_MIB_OUTSEGS);

The general approach looks sound.  I have one esoteric question
though.  If a retransmitted packet is coalesced with one that is
yet to be transmitted (a fairly unlikely scenario, but possible I
think), should it count towards OUTSEGS?

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to