On Mon, 7 Aug 2017 10:48:23 -0600
David Ahern <dsah...@gmail.com> wrote:
> On 8/4/17 10:47 AM, Stephen Hemminger wrote:
> > I will put in the libmnl version. If it doesn't work because no one sent
> > me test cases, then fine. send a patch for that.
>
> This commit:
>
> commit b6432e68ac2f1f6b4ea50aa0d6d47e72c445c71c
> Author: Stephen Hemminger <step...@networkplumber.org>
> Date: Fri Aug 4 09:52:15 2017 -0700
>
> iproute: Add support for extended ack to rtnl_talk
>
>
> Does not work. Seems like you pushed the RFC commit which was known to
> be incomplete.
Patches welcome.
> First, the Config is HAVE_MNL not HAVE_LIBMNL which is in lib/libnetlink.c.
>
> Second, changing that to HAVE_MNL does not work -- something is not
> getting passed in correctly. Just remove the semicolon on the else path:
>
> +#else
> +/* No extended error ack without libmnl */
> +static int nl_dump_ext_err(const struct nlmsghdr *nlh, nl_ext_ack_fn_t
> errfn)
> +{
> + return 0;
> +}
> +#endif
>
> and you will see that HAVE_MNL is never defined.
Ok, that I will fix.
