On 08/11/2017 06:19 PM, Roopa Prabhu wrote:
> On Thu, Aug 10, 2017 at 2:16 PM, Girish Moodalbail
> <girish.moodalb...@oracle.com> wrote:
>>
>> if (!is_valid_ether_addr(nla_data(tb[IFLA_ADDRESS]))) {
>> - pr_debug("invalid all zero ethernet address\n");
>> + NL_SET_ERR_MSG_ATTR(extack, tb[IFLA_ADDRESS],
>> + "Provided Ethernet address is
>> not unicast");
>> return -EADDRNOTAVAIL;
>
>
> keep it simple and closer to the original msg: "invalid all zero
> ethernet address"It is inaccurate though, is_valid_ether_addr will also reject multicast addresses. Matthias
signature.asc
Description: OpenPGP digital signature
