Hi Leon - the code to which this patch applies handles a data stream from our 
card's firmware to the host (over PCI).
There are device-specific registers which are accessed to transfer log data 
from our firmware to the host.
I don't think there is kernel code that we could use to perform this; this is 
not general purpose host driver logging.

Rick

-----Original Message-----
From: Leon Romanovsky [mailto:l...@kernel.org] 
Sent: Saturday, August 12, 2017 10:56 PM
To: Manlunas, Felix <felix.manlu...@cavium.com>
Cc: da...@davemloft.net; netdev@vger.kernel.org; Vatsavayi, Raghu 
<raghu.vatsav...@cavium.com>; Chickles, Derek <derek.chick...@cavium.com>; 
Burla, Satananda <satananda.bu...@cavium.com>; Ricardo Farrington 
<ricardo.farring...@cavium.com>
Subject: Re: [PATCH net-next] liquidio: update debug console logging mechanism

On Fri, Aug 11, 2017 at 06:43:14PM -0700, Felix Manlunas wrote:
> From: Rick Farrington <ricardo.farring...@cavium.com>
>
> - remove logging dependency upon global func 
> octeon_console_debug_enabled()
> - abstract debug console logging using console structure (via function ptr)
>   to allow for more flexible logging
>
> Signed-off-by: Rick Farrington <ricardo.farring...@cavium.com>
> Signed-off-by: Raghu Vatsavayi <raghu.vatsav...@cavium.com>
> Signed-off-by: Felix Manlunas <felix.manlu...@cavium.com>
> ---
>  drivers/net/ethernet/cavium/liquidio/lio_main.c    | 44 +++++++++++++++++-
>  .../net/ethernet/cavium/liquidio/octeon_console.c  | 54 
> ++++++++++++++--------
>  .../net/ethernet/cavium/liquidio/octeon_device.h   | 17 +++++--
>  3 files changed, 90 insertions(+), 25 deletions(-)
>

I'm probably missing something important, but why do you need your custom 
console implementation if kernel is full of such built-in options?

Thanks

Reply via email to