On Fri, 18 Aug 2017 15:26:01 +0200, Jiri Benc wrote: > Out of time for today, will continue the review next week. Again, feel > free to send a new version meanwhile or wait for the rest of the > review, whatever works better for you.
One more thing: before you send a new version, be sure and double check that you addressed *all* of the feedback. In this version, you still have not addressed a few things I gave feedback on in the previous version. This wastes everyone's time. It doesn't mean I'm always right, of course, but you either explain why I'm wrong or change the code. It's generally not acceptable to ignore feedback. Thank you, Jiri