On Thu, 17 Aug 2017 19:09:31 +0200 Phil Sutter <p...@nwl.cc> wrote: > - opt = get_opt(opts, "media"); > - if (strcmp(opt->val, "udp") == 0) { > + if ((opt = get_opt(opts, "media")) && > + strcmp(opt->val, "udp") == 0) {
Please don't merge assignment and comparison unless necessary for other reasons. opt = get_opt(opts, "media"); if (opt && strcmp(opt->val, "udp") == 0) {