> -----Original Message----- > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] > On Behalf Of David Miller > Sent: Wednesday, August 23, 2017 12:35 AM > Subject: Re: [PATCH v2 1/6] fsl/fman: enable FMan Keygen > > From: Madalin Bucur <madalin.bu...@nxp.com> > Date: Tue, 22 Aug 2017 20:31:01 +0300 > > > /** > > + * fman_get_keygen > > + * > > + * @fman: A Pointer to FMan device > > + * > > + * Get the handle to KeyGen module part of FM driver > > + * > > + * Return: Handle to KeyGen > > + */ > > +struct fman_keygen *fman_get_keygen(struct fman *fman) > > +{ > > + return fman->keygen; > > +} > > +EXPORT_SYMBOL(fman_get_keygen); > > Please don't do this. > > Just directly derefence the pointer in the source code to > get the keygen. > > Thank you.
Hi, The struct fman is only visible in the fman file, the fman port module uses struct fman as an opaque pointer, thus this export. Madalin
