> +     for_each_available_child_of_node(pdev->dev.of_node, child) {
> +             struct mvebu_comphy_lane *lane;
> +             struct phy *phy;
> +             int ret;
> +             u32 val;
> +
> +             ret = of_property_read_u32(child, "reg", &val);
> +             if (ret < 0) {
> +                     dev_err(&pdev->dev, "missing 'reg' property (%d)\n",
> +                             ret);
> +                     continue;
> +             }

I'm just wondering why we need this. We know how many lanes there are
from the table. So just create a generic PHY for each lane?

     Andrew

Reply via email to