I'm doing an in-depth review of d80211 right now.
One issue that leaps out: use of bitfields.
1) single-bit signed bitfields are undefined
int wep_include_iv:1;
2) bitfields in general generate HORRIBLE code. Just don't use them.
Compilers often fail to use even the most obvious simplifications.
Use flags and bitwise operators instead, like most other Linux code.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
