> -----Original Message----- > From: Jamal Hadi Salim [mailto:j...@mojatatu.com] > Sent: Wednesday, August 30, 2017 8:11 PM > To: Chris Mi <chr...@mellanox.com>; netdev@vger.kernel.org > Cc: xiyou.wangc...@gmail.com; j...@resnulli.us; da...@davemloft.net; > mawil...@microsoft.com > Subject: Re: [patch net-next v2 3/3] net/sched: Change act_api and act_xxx > modules to use IDR > > On 17-08-30 02:31 AM, Chris Mi wrote: > > Typically, each TC filter has its own action. All the actions of the > > same type are saved in its hash table. But the hash buckets are too > > small that it degrades to a list. And the performance is greatly > > affected. For example, it takes about 0m11.914s to insert 64K rules. > > If we convert the hash table to IDR, it only takes about 0m1.500s. > > The improvement is huge. > > > > But please note that the test result is based on previous patch that > > cls_flower uses IDR. > > > > Signed-off-by: Chris Mi <chr...@mellanox.com> > > Signed-off-by: Jiri Pirko <j...@mellanox.com> > > Acked-by: Jamal Hadi Salim <j...@mojatatu.com> > > Also already acked this before but you left it out in this version. If you > make > changes to the patch then you will need a new ACK. Sorry about that, Jamal. I think I need to make a note of the review comment In case I forget it. > > Dont forget to update selftests please. Sure, we will work on that.
Thanks, Chris > > cheers, > jamal
