On 08/31/2017 04:44 PM, Andrew Lunn wrote: > On Wed, Aug 30, 2017 at 05:18:45PM -0700, Florian Fainelli wrote: >> Let switch drivers indicate how many RX and TX queues they support. Some >> switches, such as Broadcom Starfighter 2 are resigned with 8 egress >> queues. > > Marvell switches also have egress queue. > > Does the SF2 have ingress queues? Marvel don't as far as i known. So > i wounder if num_rx_queues is useful?
At the moment probably not, since we are not doing anything useful other than creating the network devices with the indicated number of queues. > > Do switches in general have ingress queues? They do, at least the Starfigther 2 has, and from the Broadcom tag you can get such information (BRCM_EG_TC_SHIFT) and you could presumably record that queue on the SKB. I don't have an use case for that (yet?). -- Florian