Stephen Hemminger wrote:
On the 88E805X chipsets (used in laptops), the PHY was not getting powered
out of shutdown properly. The variable reg1 was getting reused incorrectly.
This is probably the cause of the bug.
        http://bugzilla.kernel.org/show_bug.cgi?id=6471

Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>

--- netdev-2.6.orig/drivers/net/sky2.c  2006-08-09 14:13:36.000000000 -0700
+++ netdev-2.6/drivers/net/sky2.c       2006-08-09 14:14:07.000000000 -0700
@@ -233,6 +233,8 @@
                        if (hw->ports > 1)
                                reg1 |= PCI_Y2_PHY2_COMA;
                }
+               sky2_pci_write32(hw, PCI_DEV_REG1, reg1);
+               udelay(100);
if (hw->chip_id == CHIP_ID_YUKON_EC_U) {

applied to #upstream-fixes, though I note that the obvious PCI posting bug remains.

You cannot be assured that the udelay(100) is truly effective without a flushing readl().

        Jeff


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to