The function calls to kcalloc use wrong parameter order and incorrect flags
values. GFP_KERNEL is used instead of flags now and the order is corrected.

The change was done using the following coccinelle script:

@@
expression E1,E2;
type T;
@@

-kcalloc(E1, E2, sizeof(T))
+kcalloc(E2, sizeof(T), GFP_KERNEL)

Signed-off-by: Zahari Doychev <zahari.doyc...@linux.com>
---
 drivers/net/ethernet/rocker/rocker_ofdpa.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/rocker/rocker_ofdpa.c 
b/drivers/net/ethernet/rocker/rocker_ofdpa.c
index da4e26b53a52..0653b70723a3 100644
--- a/drivers/net/ethernet/rocker/rocker_ofdpa.c
+++ b/drivers/net/ethernet/rocker/rocker_ofdpa.c
@@ -1177,7 +1177,7 @@ static int ofdpa_group_l2_fan_out(struct ofdpa_port 
*ofdpa_port,
        entry->group_id = group_id;
        entry->group_count = group_count;
 
-       entry->group_ids = kcalloc(flags, group_count, sizeof(u32));
+       entry->group_ids = kcalloc(group_count, sizeof(u32), GFP_KERNEL);
        if (!entry->group_ids) {
                kfree(entry);
                return -ENOMEM;
@@ -1456,7 +1456,7 @@ static int ofdpa_port_vlan_flood_group(struct ofdpa_port 
*ofdpa_port,
        int err = 0;
        int i;
 
-       group_ids = kcalloc(flags, port_count, sizeof(u32));
+       group_ids = kcalloc(port_count, sizeof(u32), GFP_KERNEL);
        if (!group_ids)
                return -ENOMEM;
 
-- 
2.13.0

Reply via email to