On 31/08/2017 21:18, Florian Fainelli wrote:
On 08/31/2017 12:09 PM, Mason wrote:
1) nb8800_link_reconfigure() calls phy_print_status()
which prints the "Link down" and "Link up" messages
to the console. With the patch reverted, nothing is
printed when the link goes down, and the result is
random when the link comes up. Sometimes, we get
down + up, sometimes just up.
Nothing printed when you bring down the network interface as a result of
not signaling the link down, there is a small nuance here.
Let me first focus on the "Link down" message.
Do you agree that such a message should be printed when the
link goes down, not when the link comes up?
Perhaps the issue is that the 2 following cases need to be
handled differently:
A) operator sets link down on the command-line
B) asynchronous event makes link go down (peer is dead, cable is cut, etc)
In B) the PHY state machine keeps on running, and eventually
calls adjust_link()
In A) the driver calls phy_stop() and phy_disconnect() and
therefore adjust_link() will not be called?
Regards.
