On Fri, Sep 8, 2017 at 2:52 PM, Roman Mashak <m...@mojatatu.com> wrote:
> Signed-off-by: Roman Mashak <m...@mojatatu.com>
> ---
> bridge/link.c | 16 +++++++++++++---
> 1 file changed, 13 insertions(+), 3 deletions(-)
>
> diff --git a/bridge/link.c b/bridge/link.c
> index 60200f1..9e4206f 100644
> --- a/bridge/link.c
> +++ b/bridge/link.c
> @@ -461,9 +461,19 @@ static int brlink_show(int argc, char **argv)
> }
> }
>
> - if (rtnl_wilddump_request(&rth, PF_BRIDGE, RTM_GETLINK) < 0) {
> - perror("Cannon send dump request");
> - exit(1);
> + if (show_details) {
> + if (rtnl_wilddump_req_filter(&rth, PF_BRIDGE, RTM_GETLINK,
> + (compress_vlans ?
> + RTEXT_FILTER_BRVLAN_COMPRESSED :
> + RTEXT_FILTER_BRVLAN)) < 0) {
> + perror("Cannon send dump request");
> + exit(1);
> + }
vlan information is already available with `bridge vlan show`. any
specific reason why you want it in
the link dump output ?
The problem is this might just make the link dump larger and also add
too much clutter into the regular link dump output. iproute2 detailed
dump is already a bit hard to interpret. And without compression by
default, vlan info can just take over the link dump output. It will be
hard to look for other link attributes after that :). We deploy with
thousands of vlans and without compression even bridge vlan default
output is already hard to interpret.
Can you please paste a sample default detailed output with your patch
with a few hundred vlans ?
