On 09/18/2017 03:27 PM, Vivien Didelot wrote: > Hi Florian, > > Florian Fainelli <f.faine...@gmail.com> writes: > >> @@ -649,7 +595,7 @@ static void bcm_sf2_sw_adjust_link(struct dsa_switch >> *ds, int port, >> core_writel(priv, reg, offset); >> >> if (!phydev->is_pseudo_fixed_link) >> - p->eee_enabled = bcm_sf2_eee_init(ds, port, phydev); >> + p->eee_enabled = b53_eee_init(ds, port, phydev); >> } > > I know this is a bit out-of-scope of this patch, but I have to say I am > not confortable with having still phy device stuffs in switch drivers...
Yes, this is out of scope :) > > Can this is_pseudo_fixed_link check + phy_eee_init + eee_enable be moved > up to dsa_slave_adjust_link in a future patch maybe? Not 100% positive this applies to all switches, which is why this is still largely a switch driver decision. -- Florian
