On Tue, 2017-09-19 at 12:46 +0200, Paolo Abeni wrote: .. > Acked-by: Hannes Frederic Sowa <han...@stressinduktion.org> > Signed-off-by: Paolo Abeni <pab...@redhat.com> > ---
> +/* called under RCU lock */ > +struct in_ifaddr *inet_lookup_ifaddr_rcu(struct net *net, __be32 addr) > +{ > + u32 hash = inet_addr_hash(net, addr); > + struct in_ifaddr *ifa; > + > + hlist_for_each_entry_rcu(ifa, &inet_addr_lst[hash], hash) > + if (ifa->ifa_local == addr && > + net_eq(dev_net(ifa->ifa_dev->dev), net)) > + return ifa; > + > + return NULL; > +} > + Any particular reason you do not use this helper to replace the lookup in __ip_dev_find() ? In this case, copy paste can be avoided, please avoid a future patch consolidating the things... Thanks.