On 19/09/17 14:09, Harald Welte wrote:
Hi Dave,
On Mon, Sep 18, 2017 at 09:17:51PM -0700, David Miller wrote:
This and the new dst caching code ignores any source address selection
done by ip_route_output_key() or the new tunnel route lookup helpers.
Either source address selection should be respected, or if saddr will
never be modified by a route lookup for some specific reason here,
that should be documented.
The IP source address is fixed by signaling on the GTP-C control plane
and nothing that the kernel can unilaterally decide to change. Such a
change of address would have to be decided by and first be signaled on
GTP-C to the peer by the userspace daemon, which would then update the
PDP context in the kernel.
I think we had this discussion before. The sending IP and port are not
part of the identity of the PDP context. So IMHO the sender is permitted
to change the source IP at random.
Regards
Andreas
So I guess you're asking us to document that rationale as form of a
source code comment ?
