Hi Jiri, On Thursday, September 09/21/17, 2017 at 10:55:08 +0200, Jiri Pirko wrote: > Thu, Sep 21, 2017 at 09:33:36AM CEST, rahul.lakkire...@chelsio.com wrote: > >From: Kumar Sanghvi <kuma...@chelsio.com> > > > >Add support for offloading tc-flower flows having > >vlan actions: pop, push and modify. > > > >Signed-off-by: Kumar Sanghvi <kuma...@chelsio.com> > >Signed-off-by: Rahul Lakkireddy <rahul.lakkire...@chelsio.com> > >Signed-off-by: Ganesh Goudar <ganes...@chelsio.com> > >--- > > .../net/ethernet/chelsio/cxgb4/cxgb4_tc_flower.c | 43 > > ++++++++++++++++++++++ > > 1 file changed, 43 insertions(+) > > > >diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_flower.c > >b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_flower.c > > [...] > > > >+ switch (vlan_action) { > >+ case TCA_VLAN_ACT_POP: > >+ break; > >+ case TCA_VLAN_ACT_PUSH: > >+ case TCA_VLAN_ACT_MODIFY: > >+ if (proto != ETH_P_8021Q) { > >+ netdev_err(dev, > >+ "%s: Unsupp. vlan proto\n", > > Don't wrap this. Also "Unsupp."vs"Unsupported". Please be consistent.
Thank you for pointing this. I will take care of this in V2. > > > >+ __func__); > >+ return -EOPNOTSUPP; > >+ } > >+ break; > >+ default: > >+ netdev_err(dev, "%s: Unsupported vlan action\n", > >+ __func__); > >+ return -EOPNOTSUPP; > >+ } > > } else { > > netdev_err(dev, "%s: Unsupported action\n", __func__); > > return -EOPNOTSUPP; > >-- > >2.14.1 > >