On Tue, Oct 03, 2017 at 09:46:52PM -0700, David Miller wrote:
> From: Stefan Hajnoczi <stefa...@redhat.com>
> Date: Tue, 3 Oct 2017 11:39:42 -0400
>
> > +static int sk_diag_fill(struct sock *sk, struct sk_buff *skb,
> > + u32 portid, u32 seq, u32 flags)
> > +{
> > + struct nlmsghdr *nlh;
> > + struct vsock_diag_msg *rep;
> > + struct vsock_sock *vsk = vsock_sk(sk);
>
> Please order local variables from longest to shortest line.
>
> > +static int vsock_diag_dump(struct sk_buff *skb, struct netlink_callback
> > *cb)
> > +{
> > + struct vsock_diag_req *req;
> > + unsigned int table;
> > + unsigned int bucket;
> > + unsigned int last_i;
> > + unsigned int i;
> > + struct vsock_sock *vsk;
> > + struct net *net;
>
> Likewise.
Will fix in v2.
