From: Jakub Kicinski <jakub.kicin...@netronome.com>
Date: Sun, 8 Oct 2017 18:25:45 -0700

> On Sun, 8 Oct 2017 01:19:17 +0300, Alexey Dobriyan wrote:
>> Buffer length passed into this hook is always IFNAMSIZ which is 16.
>> 
>> Code savings on x86_64:
>> 
>>      add/remove: 0/0 grow/shrink: 1/9 up/down: 2/-45 (-43)
>>      function                                     old     new   delta
>>      rocker_cmd_get_port_settings_phys_name_proc     179     181      +2
>>      rocker_port_get_phys_port_name                62      61      -1
>>      mlxsw_sx_port_get_phys_port_name              54      50      -4
>>      mlx5e_rep_get_phys_port_name                  61      57      -4
>>      efx_get_phys_port_name                        50      46      -4
>>      dsa_slave_get_phys_port_name                  54      50      -4
>>      bnxt_vf_rep_get_phys_port_name                69      65      -4
>>      bnxt_get_phys_port_name                       70      65      -5
>>      mlxsw_sp_port_get_phys_port_name             116     107      -9
>>      nfp_port_get_phys_port_name                  180     170     -10
>> 
>> Signed-off-by: Alexey Dobriyan <adobri...@gmail.com>
> 
> I don't think the gains justify the additional burden on backports.

Yeah I agree, this one is not really worth the pain.

Reply via email to