> +int __init ehea_module_init(void) > +{ > + int ret = -EINVAL; > + > + EDEB_EN(7, ""); > + > + printk(KERN_INFO "IBM eHEA Ethernet Device Driver (Release %s)\n", > + DRV_VERSION); > + > + > + ret = ibmebus_register_driver(&ehea_driver); > + if (ret) { > + EDEB_ERR(4, "Failed registering eHEA device driver on ebus"); > + return -EINVAL; > + } > + > + EDEB_EX(7, ""); > + return 0; > +}
Function should be static and could be shortened to the single line return ibmebus_register_driver(&ehea_driver); , I guess :) - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html