Hi,
Ivan Khoronzhuk <[email protected]> writes:
[...]
>> +
>> +static int cbs_enqueue_soft(struct sk_buff *skb, struct Qdisc *sch)
>> +{
>> + struct cbs_sched_data *q = qdisc_priv(sch);
>> +
>> + if (sch->q.qlen == 0 && q->credits > 0) {
>> + /* We need to stop accumulating credits when there's
>> + * no packet enqueued packets and q->credits is
> no packet -> no
Ugh. Fixed.
>
>> + * positive.
>> + */
>> + q->credits = 0;
>> + q->last = ktime_get_ns();
>> + }
>> +
>> + return qdisc_enqueue_tail(skb, sch);
>> +}
>> +
[...]
>> +static struct sk_buff *cbs_dequeue_soft(struct Qdisc *sch)
>> +{
>> + struct cbs_sched_data *q = qdisc_priv(sch);
>> + s64 now = ktime_get_ns();
>> + struct sk_buff *skb;
>> + s64 credits;
>> + int len;
>> +
>> + if (q->credits < 0) {
>> + credits = timediff_to_credits(now - q->last, q->idleslope);
> Maybe be better to add small optimization by moving some calculations from
> data
> path, I mean, save idle_slope in bytes instead of kbit and converting it for
> every packet. Both delay_from_credits() and timediff_to_credits() is used only
> once and with idle_slope only...and both of them converting it.
>
> Same for credits_from_len() and send slope, save it in units of port_rate.
>
Done. Thanks.
Cheers,
--
Vinicius
