> -----Original Message----- > From: Andrew Lunn [mailto:and...@lunn.ch] > Sent: Sunday, October 15, 2017 9:34 PM > To: Madalin-cristian Bucur <madalin.bu...@nxp.com> > Cc: netdev@vger.kernel.org; da...@davemloft.net; f.faine...@gmail.com; > vivien.dide...@savoirfairelinux.com; jun...@outlook.com; linux- > ker...@vger.kernel.org > Subject: Re: [PATCH v2 2/5] dpaa_eth: move of_phy_connect() to the eth > driver > > On Fri, Oct 13, 2017 at 05:50:09PM +0300, Madalin Bucur wrote: > > Signed-off-by: Madalin Bucur <madalin.bu...@nxp.com> > > --- > > drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 48 +++++++++++-- > > drivers/net/ethernet/freescale/fman/mac.c | 97 ++++++------------- > ------- > > drivers/net/ethernet/freescale/fman/mac.h | 5 +- > > 3 files changed, 66 insertions(+), 84 deletions(-) > > > > diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c > b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c > > index 4225806..7cf61d6 100644 > > --- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c > > +++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c > > @@ -2435,6 +2435,48 @@ static void dpaa_eth_napi_disable(struct > dpaa_priv *priv) > > } > > } > > > > +static void dpaa_adjust_link(struct net_device *net_dev) > > +{ > > + struct mac_device *mac_dev; > > + struct dpaa_priv *priv; > > + > > + priv = netdev_priv(net_dev); > > + mac_dev = priv->mac_dev; > > + mac_dev->adjust_link(mac_dev); > > +} > > + > > +static int dpaa_phy_init(struct net_device *net_dev) > > +{ > > + struct mac_device *mac_dev; > > + struct phy_device *phy_dev; > > + struct dpaa_priv *priv; > > + > > + priv = netdev_priv(net_dev); > > + mac_dev = priv->mac_dev; > > + > > + phy_dev = of_phy_connect(net_dev, mac_dev->phy_node, > > + &dpaa_adjust_link, 0, > > + mac_dev->phy_if); > > + if (!phy_dev) { > > + netif_err(priv, ifup, net_dev, "init_phy() failed\n"); > > + return -ENODEV; > > + } > > + > > + /* Remove any features not supported by the controller */ > > + phy_dev->supported &= mac_dev->if_support; > > + > > + /* Enable the symmetric and asymmetric PAUSE frame advertisements, > > + * as most of the PHY drivers do not enable them by default. > > + */ > > Hi Madalin > > This is just moving code around, so the patch is O.K. However, it > would be nice to have a followup patch. This comment is wrong. The phy > driver should never enable symmetric and asymmetric PAUSE frames. The > MAC needs to, because only the MAC knows if the MAC supports pause > frames. > > Andrew
Hi Andrew, This is obsolete and it will be removed, I'll send a v3. It remained there from a time it used to be valid (the original DPAA Ethernet driver was developed and maintained out of tree since about 9 years ago). I see this thread on the subject which is relatively recent: https://www.spinics.net/lists/netdev/msg404288.html Thanks, Madalin
