Re: [PATCH v7 02/10] arm: dts: sunxi: Restore EMAC changes

[Andrew Lunn]

> index e1dba9ffa94b..f2292deaa590 100644
> --- a/arch/arm/boot/dts/sun8i-h3-bananapi-m2-plus.dts
> +++ b/arch/arm/boot/dts/sun8i-h3-bananapi-m2-plus.dts
> @@ -52,6 +52,7 @@
>       compatible = "sinovoip,bpi-m2-plus", "allwinner,sun8i-h3";
>  
>       aliases {
> +             ethernet0 = &emac;
>               serial0 = &uart0;
>               serial1 = &uart1;
>       };
> @@ -111,6 +112,24 @@
>       status = "okay";
>  };
>  
> +&emac {
> +     pinctrl-names = "default";
> +     pinctrl-0 = <&emac_rgmii_pins>;
> +     phy-supply = <&reg_gmac_3v3>;
> +     phy-handle = <&ext_rgmii_phy>;
> +     phy-mode = "rgmii";
> +
> +     allwinner,leds-active-low;
> +     status = "okay";
> +};
> +
> +&external_mdio {
> +     ext_rgmii_phy: ethernet-phy@1 {
> +             compatible = "ethernet-phy-ieee802.3-c22";
> +             reg = <0>;
> +     };

The reg value should match the @ value.

    Andrew