On Tue, Oct 24, 2017 at 11:53:20AM +0800, Herbert Xu wrote: > On Mon, Oct 23, 2017 at 10:50:43PM -0500, Gustavo A. R. Silva wrote: > > > > Quoting Herbert Xu <herb...@gondor.apana.org.au>: > > > > >On Mon, Oct 23, 2017 at 01:18:57PM -0500, Gustavo A. R. Silva wrote: > > >>Use BUG_ON instead of if condition followed by BUG. > > >> > > >>This issue was detected with the help of Coccinelle. > > >> > > >>Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> > > > > > >I think this patch is terrible. Why on earth is Coccinelle even > > >warning about this? > > > > > >If anything we should be converting these constructs to not use > > >BUG. > > > > > > > Yeah, and under this assumption the original code is even worse. > > No your patch makes it worse. The original construct makes it > clear that the conditional is real code and not just some debugging > aid. > > With your patch, real code is now inside BUG_ON.
fwiw I had the same argument earlier: https://lkml.org/lkml/2017/10/9/1139
